Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that screenfull can be false #142

Closed
s-h-a-d-o-w opened this issue Jun 15, 2019 · 1 comment · Fixed by #154
Closed

Document that screenfull can be false #142

s-h-a-d-o-w opened this issue Jun 15, 2019 · 1 comment · Fixed by #154
Labels
enhancement help wanted

Comments

@s-h-a-d-o-w
Copy link
Contributor

s-h-a-d-o-w commented Jun 15, 2019 •
edited

Trying to use the new types has made me aware of this fact. It seems that wherever you use screenfull, you should actually wrap the block in a if (screenfull).

Or of course use if (screenfull && screenfull.enabled).
Which might also clear up this confusion.

Or... if a browser doesn't support full screen at all, don't return false but instead {enabled: false}.
@sindresorhus
Copy link
Owner

Or... if a browser doesn't support full screen at all, don't return false but instead {enabled: false}.

Yeah, that would be nicer.

s-h-a-d-o-w added a commit to s-h-a-d-o-w/screenfull.js that referenced this issue Aug 3, 2019
@s-h-a-d-o-w
Unifies checking for fullscreen availability
c11ac0d 
screenfull now always provides an object that at least contains
`enabled`, making a seperate check for `screenfull` being `false`
unnecessary.

Fixes sindresorhus#142
@s-h-a-d-o-w s-h-a-d-o-w mentioned this issue Aug 3, 2019
Closed
s-h-a-d-o-w added a commit to s-h-a-d-o-w/screenfull.js that referenced this issue Sep 8, 2019
@s-h-a-d-o-w
Unifies checking for fullscreen availability
7191e0b 
screenfull now always provides an object that at least contains
`enabled`, making a seperate check for `screenfull` being `false`
unnecessary.

Fixes sindresorhus#142
s-h-a-d-o-w added a commit to s-h-a-d-o-w/screenfull.js that referenced this issue Sep 8, 2019
@s-h-a-d-o-w
Unifies checking for fullscreen availability
82374e2 
screenfull now always provides an object that at least contains
`enabled`, making a seperate check for `screenfull` being `false`
unnecessary.

Fixes sindresorhus#142
s-h-a-d-o-w added a commit to s-h-a-d-o-w/screenfull.js that referenced this issue Sep 8, 2019
@s-h-a-d-o-w
Unifies checking for fullscreen availability
d040c30 
screenfull now always provides an object that at least contains
`enabled`, making a seperate check for `screenfull` being `false`
unnecessary.

Fixes sindresorhus#142
s-h-a-d-o-w added a commit to s-h-a-d-o-w/screenfull.js that referenced this issue Sep 8, 2019
@s-h-a-d-o-w
Unifies checking for fullscreen availability
3a7cd4d 
screenfull now always provides an object that at least contains
`enabled`, making a seperate check for `screenfull` being `false`
unnecessary.

Fixes sindresorhus#142
@s-h-a-d-o-w s-h-a-d-o-w mentioned this issue Sep 8, 2019
Merged
sindresorhus pushed a commit that referenced this issue Sep 9, 2019
@s-h-a-d-o-w @sindresorhus
Unify checking for fullscreen availability (#154)
633ea78 
Fixes #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify checking for fullscreen availability s-h-a-d-o-w/screenfull.js
2 participants
@sindresorhus @s-h-a-d-o-w