Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'exit' does not exist on type 'Screenfull | { isEnabled: false; }' #165

Closed
chandrasekharu opened this issue Dec 27, 2019 · 2 comments

Comments

@chandrasekharu
Copy link

chandrasekharu commented Dec 27, 2019

Hi I am in the process of upgrading my angular application from 5 to 8

facing a error where it says Property 'exit' does not exist on type 'Screenfull

I want to toggle 'summary-fullscreen' element section only here

I got two errors actually after upgrade.

  1. In showfullscreen function I used to have screenfull.enabled I renamed it to screenfull.isEnabled the error went off later I got the issue with property exit in closeFullscreen() funtion

showFullScreen() {
const goFullScreenTarget = document.getElementById('summary-fullscreen');
if (screenfull.isEnabled) {
screenfull.request(goFullScreenTarget);
}
}
closeFullScreen() {
screenfull.exit();
}

another issue, Property 'on' does not exist on type 'Screenfull

screenfull.on('change', () => {
this.isFullscreen = !this.isFullscreen;
});

@chandrasekharu
Copy link
Author

@sindresorhus How can you close the issue without giving solution to this. it's still showing the error as where it says Property 'exit' does not exist on type 'Screenfull please explain the fix

@sindresorhus
Copy link
Owner

@chandrasekharu "closed this in f0a14a3". It was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants