Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need review: Add support for Safari mobile #175

Closed
bahung1221 opened this issue May 30, 2020 · 1 comment
Closed

Need review: Add support for Safari mobile #175

bahung1221 opened this issue May 30, 2020 · 1 comment

Comments

@bahung1221
Copy link

bahung1221 commented May 30, 2020

Hi there,

I want to create an PR to add support for safari mobile (iPhone). I successful request fullscreen for video element on my company project (that work perfect for iPhone), so now I want to add this feature to screenfull.js.

Following this webkit API document: WebKit JS HTMLVideoElement.

But I faced a problem, screenfull.js stick all method (except request method) to document element while all API of Webkit HTMLVideoElement above only work on video element not the document.

Synonymous we must refactor current structure of project, i did it for all methods in my fork repo, but i don't know what is better way for refactor instance properties (isFullscreen, element, isEnabled) that only check on document element

So please help to review my commit and give me some advise about it, thank you very much,
Happy Coding!

My Commit

@sindresorhus
Copy link
Owner

I'm unfortunately not interested in adding support for the WebKit video element fullscreen thing. It's too different from the rest and this package is done feature-wise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants