Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssr issue #190

Closed
basaran opened this issue Sep 15, 2021 · 1 comment
Closed

ssr issue #190

basaran opened this issue Sep 15, 2021 · 1 comment

Comments

@basaran
Copy link

basaran commented Sep 15, 2021 •
edited

Hello, a sveltekit library I was trying to use was using screenful. It would cause issues during SSR, and I had to monkey patch it like this to make it work:

 if (typeof window !== "undefined")  window.screenfull = { isEnabled: false };
...
 if (typeof window !== "undefined") window.screenfull = screenfull;

I can send a PR but not sure if there would be other consequences to these changes.

meigo/svelte-video-player#10
@basaran
Copy link
Author

basaran commented Sep 30, 2021

closing due to inactivity

@basaran basaran closed this as completed Sep 30, 2021
@ramiel ramiel mentioned this issue Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix in SSR mode ramiel/screenfull
1 participant
@basaran