Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenfull.enabled = true in Android 4.3, but not supported #56

Closed
chaenu opened this issue Jul 23, 2014 · 2 comments
Closed

screenfull.enabled = true in Android 4.3, but not supported #56

chaenu opened this issue Jul 23, 2014 · 2 comments

Comments

@chaenu
Copy link

chaenu commented Jul 23, 2014

First of all, thank you for your work!

I've noticed that screenfull.enabled returns true on the Samsung Galaxy S4 / Android 4.3 Stock Browser, where the fullscreenAPI isn't supported. But this is not a bug in screenfull, as document.webkitFullscreenEnabled returns true and the stock browser is pretending to support the fullscreenAPI (see https://code.google.com/p/chromium/issues/detail?id=180734).
The HTC One / Android 4.4.2 Stock Browser returns undefined as expected and therefore screenfull.enabled is false.

Do you see any possibility to deal with this false behaviour?

@sindresorhus
Copy link
Owner

Not really. Only way I can think of is browser-sniffing and not super interested in adding that.

@chaenu
Copy link
Author

chaenu commented Jul 25, 2014

Yes, I fully understand this. Thanks for your fast response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants