Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate onchange/onerror? #63

Closed
ben-eb opened this issue Dec 16, 2014 · 5 comments · Fixed by #64
Closed

Deprecate onchange/onerror? #63

ben-eb opened this issue Dec 16, 2014 · 5 comments · Fixed by #64

Comments

@ben-eb
Copy link
Contributor

ben-eb commented Dec 16, 2014

Initially had an idea to add an unbind method to remove all event handlers that screenfull creates and send a patch, but would much rather just clean up my own events that I registered through addEventListener. Would be happy to submit a patch removing these handlers if you're OK with it. 👍
@sindresorhus
Copy link
Owner

👍

@ben-eb ben-eb mentioned this issue Dec 22, 2014
Merged
sindresorhus added a commit that referenced this issue Dec 22, 2014
@sindresorhus
Merge pull request #64 from ben-eb/patch-63
0910a39 
Remove onchange/onerror handlers. Fixes #63.
@ben-eb
Copy link
Contributor Author

ben-eb commented Dec 22, 2014

Awesome, thanks! 🍻

@naheller
Copy link

@ben-eb I'm still seeing onchange listed in the readme. Is this a mistake?

@ben-eb
Copy link
Contributor Author

ben-eb commented Apr 11, 2019

The API was changed after this patch was landed, I don't know when. It's been over 4 years since. 😉

@sindresorhus
Copy link
Owner

Seems it was added back again in #98 ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove onchange/onerror handlers. Fixes #63.
3 participants
@sindresorhus @ben-eb @naheller