Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for options #182

Merged
merged 8 commits into from Dec 24, 2020
Merged

Add support for options #182

merged 8 commits into from Dec 24, 2020

Conversation

silltho
Copy link
Contributor

@silltho silltho commented Oct 27, 2020

I needed the support of the FullscreenOptions to hide the navbar on mobile devices. Since the PR #148 related to the issue was closed I wanted to share this with you.

resolves #114


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@silltho
Copy link
Contributor Author

silltho commented Nov 1, 2020

summoning @sindresorhus 😄

@sindresorhus
Copy link
Owner

You need to add it to the readme too.

@sindresorhus sindresorhus changed the title adds FullscreenOptions support Add support for options Nov 28, 2020
@silltho
Copy link
Contributor Author

silltho commented Nov 30, 2020

Good point. I updated the api documentation and added an example how to hide navigation ui on mobile devices.

@sindresorhus
Copy link
Owner

You need to update the .toggle() docs in the readme too.

@sindresorhus sindresorhus merged commit 0092521 into sindresorhus:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support requestFullscreen() options
2 participants