Force interactive shell for common shells

[silverwind]

Spawned by sindresorhus/fix-path#3

To handle cases like where zsh users wrongly put PATH modifications into .zshrc instead of zshenv, we should consider using the -i flag to force an interactive shell to obtain the full PATH.

What needs to be done is to investigate which shells have an -i flag or similar.

[sindresorhus]

Hah, I was just going to open this issue. Definitely.

[silverwind]

bash, zsh, dash, fish come to mind as popular shells, anything else you'd see worth investigating?

[sindresorhus]

sh

[sindresorhus]

Thanks @silverwind :D

[silverwind]

Looks -iis ubiquitous to all five tested shells, so I went ahead and changed it. With my pretty heavy .zshrc it increased the execution time of that execFile quite a bit, but I say it's worth it for accuracy.

[sindresorhus]

Definitely worth it. Even I initially my environment variables in .zshrc.

[sindresorhus]

@silverwind I owe you many times. Let me know whenever you would like some feedback/brainstorming on anything at all ;)

[silverwind]

Happy to help. I'll make sure to use your ama if anything comes to mind 😉