Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contractions/possessions removal causes unwanted behavior #72

Closed
hanneskuettner opened this issue May 17, 2023 · 0 comments · Fixed by #73
Closed

Contractions/possessions removal causes unwanted behavior #72

hanneskuettner opened this issue May 17, 2023 · 0 comments · Fixed by #73

Comments

@hanneskuettner
Copy link
Contributor

hanneskuettner commented May 17, 2023 •
edited

The contractions/possessions removal (PR #71) causes unwanted behavior when it is invoked with a partial string which happens to end on a -s or -t.

In that case the - is removed which might be unwanted if this library is used for live input transformation, eg in directus/directus#18352
For example the user starts to type article title which gets transformed to article-t as soon as the user types the t, which then incorrectly gets turned into articlet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Perform contraction/possession replacement before main pattern replacement hanneskuettner/slugify
1 participant
@hanneskuettner