Add timestamp to the JSON output #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnud
commented
Oct 27, 2020
gnud
commented
- Updated readme to include batch example
- The timestamp is only included via json argument and verbose all together, providing ability to monitor the results via some tool
- Updated readme to include batch example
sindresorhus
requested changes
Oct 28, 2020
|
Can you mention in the readme that the JSON output also includes a timestamp? |
sindresorhus
changed the title
Added suggested changes Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Added long argument names as suggested
gnud
commented
Oct 28, 2020
I don't understand what this means. You can confirm yourself. |
|
You still need to do #67 (comment) |
Describing the new timestamp property in the readme
sindresorhus
reviewed
Nov 2, 2020
| while true; do sleep 30; node cli.js --verbose --json; done >> ~/net.log | ||
| ``` | ||
|
|
||
| **Note**: using the **"--verbose"** and **"--json"** will include a timestamp **e.g**: "1603971242534" property generated now in form of a timestamp, good for recording the metrics in some monitoring software. |
There was a problem hiding this comment.
This should be documented generally. It's not specific to "batch monitoring".
And I think the text should be slightly better written and formatted.
|
@gnud Friendly bump :) |
|
Closing for lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.