Attempt to convert to babel plugin #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #20 |
sindresorhus
requested changes
Jul 7, 2019
| "test": "xo --ignore ./test/fixtures && npm run build && ava test --verbose", | ||
| "lint-fix": "xo --ignore ./test/fixtures --fix", | ||
| "test:watch": "npm run build && npm run test -- --watch", | ||
| "prepublishOnly": "npm run clean && npm run build" |
There was a problem hiding this comment.
There's no point on transpiling the module code. That just adds a lot of overhead for no gain.
| "babel-cli": "^6.4.5", | ||
| "babel-core": "^6.26.3", | ||
| "babel-preset-es2015": "^6.24.1", | ||
| "babel-preset-stage-0": "^6.24.1", |
| ).toString(); | ||
|
|
||
| test(`should ${caseName}`, t => { | ||
| t.is(trim(actual), trim(expected)); |
There was a problem hiding this comment.
Uhm
Suggested change
| t.is(trim(actual), trim(expected)); | |
| t.is(actual.trim(), expected.trim()); |
|
Closing for lack of activity. |
Closed
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I converted this repo to a Babel Plugin, is the firs time I do something babel related, let me know any changes or improvements.
I have a identical version of this npm package working on https://www.npmjs.com/package/babel-plugin-noob. I uploaded it because I wanted to test all usage cases, hope you don't mind.
Fixes #20