Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Change #5

Closed
WORMSS opened this issue Sep 12, 2019 · 2 comments
Closed

Breaking Change #5

WORMSS opened this issue Sep 12, 2019 · 2 comments

Comments

@WORMSS
Copy link

WORMSS commented Sep 12, 2019

Hello, I was just wondering what the breaking change was from 2.2.0 to 3.0.0?
As far as I can tell, all still returns an array, random() still returns a string?
@sindresorhus
Copy link
Owner

https://github.com/sindresorhus/supervillains/releases

@WORMSS
Copy link
Author

WORMSS commented Sep 12, 2019

This does not answer the question. Adding a typescript definition doesn't break the code code.
Updating unique-random-array "says" it needs node 8, but not seeing any evidence of it requiring it. since that updated it dependence on unique-random but that can run on node 6..

So I ask again, what 'was' the breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @WORMSS