Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

was it intentional to lose support for 0.10 and 0.12? #7

Closed
sam-github opened this issue Jun 15, 2016 · 1 comment
Closed

was it intentional to lose support for 0.10 and 0.12? #7

sam-github opened this issue Jun 15, 2016 · 1 comment

Comments

@sam-github
Copy link

Your package.json still says >= 0.10, but its use of const is invalid in at least <= 0.12. I tried changing const to var, and the ava tests pass, though xo enforces an unportable coding style, so it fails.

We've backdated to 1.x, but if it was intentional, updating the package.json would be helpful.

s/username (master * u=) % npm test

> username@2.2.0 test /Users/sam/s/username
> xo && ava


  index.js:2:1
  ✖   2:1  Unexpected var, use let or const instead.  no-var
  ✖   3:1  Unexpected var, use let or const instead.  no-var
  ✖   4:1  Unexpected var, use let or const instead.  no-var
  ⚠  48:4  Unexpected todo comment.                   no-warning-comments

  3 errors
  1 warning
npm ERR! Test failed.  See above for more details.

Strangely, all those fancy unicode chars above show up as plain whitespace in my terminal... but showed up when I cut-n-pasted the whitespace into github.

@sindresorhus
Copy link
Owner

sindresorhus commented Jun 15, 2016

Oh yeah. That's an oversight. The module requires Node.js 4 or later. See: 80c8ad4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants