Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support pasting images #20

Closed
michaelrommel opened this issue Oct 5, 2021 · 3 comments
Closed

Update to support pasting images #20

michaelrommel opened this issue Oct 5, 2021 · 3 comments

Comments

@michaelrommel
Copy link

Dear Sindre and team,

since it is pretty complicated to get clipboard synchronization when working on remote systems, while the local one is a Windows WSL instance (the story actually fills pages by now...) I started writing a distributed clipboard sync daemon in node.js.

While working on that goal, I started using clipboardy and quickly discovered some things, that I wanted to change. E.g. that the windows tool produces error messages, when there is no text on the clipboard, but instead images etc. So I got the sourcecode, updated it to first check for various string markers and got rid of the panic messages. Then I realised, that I really also wanted to be able to paste images from the clipboard (later then remotely...). I implemented CF_BITMAP support, since that was in the clipboard-win crate. I then found out, that transparency is then missing. So I implemented PNG and DIBV5 support...

Now I understand, that this is now much larger and may not even go in the direction, that you want to take this project to. I hereby wanted to share a link to my repo in cast you just wanted to have a look around or anything really. If you are interested in PRs, please let me know, what you would want to take over... I probably will maintain my fork, since I may add further things to it, like copying images into, pasting data-urls from images etc.

Please let me know, what you think and how you would like to be credited further (I already left Sindre's name in the help message and Readme etc.) Or if you want me to remove it and not be associated with my code... Which I would understand as this is my very first rust project.

Here is the repo link: https://github.com/michaelrommel/coppas-platform-win

Thanks for providing me with such a good starting point. (Hm, and you got me to learn Rust... Don't know, if that is a good thing, though... 😜)

Michael.

@sindresorhus
Copy link
Owner

I'm happy to receive pull requests to improve the handling of text, but I'm not interested in adding image handling.

@sindresorhus
Copy link
Owner

Also feel free to add your package to the related section in the readme.

@michaelrommel
Copy link
Author

I'm happy to receive pull requests to improve the handling of text, but I'm not interested in adding image handling.

I absolutely understand that. If I can come up with a small changeset for the improvements I made, I'll send a PR and close this issue for now. Also once my project has reached a stable stand and is working, then I might ask for inclusion in the related section.

Thanks for the quick reply and for all the other modules!

Michael.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants