Causing aroung 800ms delay between version 3.2.0 and 3.3.0

[Deepanshu2017]

The scenario -

• I have an Azure NodeJS function
  • Azure function has a dependency on CosmosDB NodeJS package
  • Azure Cosmos DB NodeJS package has dependency over os-name package
  • os-name package has the dependency over windows-release package

I had a production system running on Cosmos NodeJS package (version 3.6.2) and recently I made some changes and tried to deploy the new code over the production. I started to see the latency of around 800ms in cosmos DB insertion call. The cosmos DB package version was the same so the issue was in one of the dependency. I manually checked each and every package on which Cosmos DB and it's dependencies are dependent on (trust I checked a lot of code and releases) and could drill down to the specific version which is causing the issue.

The Windows-release package version 3.3.0 is causing the Cosmos to delay the result by 800ms to 1000ms. While with Windows-release package version 3.2.0 Cosmos DB doesn't show this much of delay. (Given that everything in the system was constant and every other factor which might impact the results had been eliminated).

When comparing Windows-release 3.3.0 with Windows-release 3.2.0, I found that the only part in the code that has been changed is the below snippet

windows-release/index.js

Lines 36 to 40 in 39b78e7

	try {
	stdout = execa.sync('powershell', ['(Get-CimInstance -ClassName Win32_OperatingSystem).caption']).stdout || '';
	} catch (_) {
	stdout = execa.sync('wmic', ['os', 'get', 'Caption']).stdout || '';
	}

Basically Windows-release moved from wmic to use PowerShell by default in this commit and in case PowerShell fails, fallback to wmic and I suspect that due to this fallback and changing default from wmic to PowerShell is causing the delay.

[Deepanshu2017]

SideNote:
I don't necessarily know whether I should create this issue here or in the os-name package or in CosmosDB. But anyway creating the issue here.
Also seems like, you are the owner of this package as well as the owner of os-name package.

[sindresorhus]

// @landsfiskalen

[landsfiskalen]

Hmmm, weird. @Deepanshu2017 could you try and change the order of the powershell and wmic command?

[Deepanshu2017]

@landsfiskalen But the thing is, I really don't know if I can do that in your code and push the deployment since it was on the Azure function app.

The confirmed thing is, changing from 3.3.0 to 3.2.0 made resolved everything.

[Deepanshu2017]

One thing I can try is, try to run the 3.3.0 and 3.2.0 on my local system and check if I can replicate the issue on local.

[landsfiskalen]

That would be great if you could!