add --quiet feature #131
Merged
add --quiet feature #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test? |
|
yup, doing that and one more question does have to implement the same code in |
Yes |
| @@ -64,7 +65,9 @@ function mergeReports(reports) { | |||
| function runEslint(paths, opts) { | |||
| var config = optionsManager.buildConfig(opts); | |||
| var engine = new eslint.CLIEngine(config); | |||
| return engine.executeOnFiles(paths, config); | |||
| var report = engine.executeOnFiles(paths, config); | |||
| report.results = opts.quiet ? eslint.CLIEngine.getErrorResults(report.results) : report.results; | |||
There was a problem hiding this comment.
Add a new processReport(report, opts) function that contains this common code:
function processReport(report, opts) {
report.results = ....
return report;
}
|
LGTM |
| const filepath = await tempWrite('// TODO: quiet\nconsole.log()\n', 'x.js'); | ||
|
|
||
| try { | ||
| await execa('../cli.js', ['--no-local', '--quiet', '--reporter=compact', filepath]); |
There was a problem hiding this comment.
You can use t.throws here. It returns the error which you then can check.
https://github.com/avajs/ava#throwsfunctionpromise-error-message
|
|
||
| test('quiet option', async t => { | ||
| const filepath = await tempWrite('// TODO: quiet\nconsole.log()\n', 'x.js'); | ||
| var err = await t.throws(execa('../cli.js', ['--no-local', '--quiet', '--reporter=compact', filepath])); |
|
👍 Awesome :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #125