Add failing test for negative .gitignore rules #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stumbled upon another issue, a test on Windows is not actually working: test('ignore files in .gitignore', async t => {
const cwd = path.join(__dirname, 'fixtures/gitignore');
try {
const result = await execa('../../../cli.js', ['--no-local'], {cwd});
} catch (err) {
t.is(err.stdout.indexOf('foo.js'), -1);
t.true(err.stdout.indexOf('bar.js') !== -1);
}
// No error gets thrown, therefore the test passes even though it shouldn't.
});That is why my 'failing' test ended up passing and that is why the build is broken. |
schnittstabil
suggested changes
Mar 20, 2017
test/cli.js
Outdated
| await execa('../../../cli.js', ['--no-local'], {cwd}); | ||
| const result = await execa('../../../cli.js', ['--no-local'], {cwd}); | ||
| console.log(result, result.stdout, result.stderr); | ||
| t.fail(); | ||
| } catch (err) { | ||
| t.is(err.stdout.indexOf('foo.js'), -1); | ||
| t.true(err.stdout.indexOf('bar.js') !== -1); | ||
| } | ||
| }); |
There was a problem hiding this comment.
- try {
- await execa('../../../cli.js', ['--no-local'], {cwd});
- } catch (err) {
- t.false(err.stdout.includes('foo.js'));
- t.true(err.stdout.includes('bar.js'));
- }
+ const err = await t.throws(execa('../../../cli.js', ['--no-local'], {cwd}));
+ t.false(err.stdout.includes('foo.js'));
+ t.true(err.stdout.includes('bar.js'));
test/cli.js
Outdated
| } catch (err) { | ||
| t.is(err.stdout.indexOf('foo.js'), -1, 'Should not lint foo.js'); | ||
| } | ||
| }); |
There was a problem hiding this comment.
const err = await t.throws(execa(`../../../cli.js`, [`${cwd}/bar.js`, '--no-local'], {cwd});
t.is(err.stdout.indexOf('foo.js'), -1, 'Should not lint foo.js');There was a problem hiding this comment.
This is cool! I didn't know that you could await t.throws and then make further assertions with the error. Thanks and I changed it!
|
Fixed by #204. |
|
Thanks for the tests @JonnyBurger 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test demonstrates the bug that negative entries in
.gitignorenow get linted even if we don't include them in the list of files we want linted.See: #195 (comment)