Parse nested gitignores correctly

[marionebl]

• Depends on Recursive glob patterns #201
• Credits for original bugfix go to @schnittstabil

[sindresorhus]

Looks good to me.

@marionebl Can you rebase on master?

@schnittstabil Looks good to you?

[schnittstabil]

very minor: this can be done outside of the cli function

[sindresorhus]

Nah. It's not used outside the function, so better to keep it in context and it's doesn't really affect performance to keep it there.

[schnittstabil]

Sorry, I dunno why I've missed this PR. I'll try to review it at this weekend.

[schnittstabil]

Mostly minor changes.

[schnittstabil]

Just a small suggestion:

 const getGitIgnores = opts => {
-       const ignores = opts.ignores || [];
+       const ignore = opts.ignores || [];
        const cwd = opts.cwd || process.cwd();
 
        return globby
-               .sync('**/.gitignore', {
-                       ignore: ignores,
-                       cwd: cwd
-               })
+               .sync('**/.gitignore', {ignore, cwd})
                .map(filename => {
                        const fullFilename = path.join(cwd, filename);
                        const patterns = parseGitignore(fullFilename);

[marionebl]

done

[schnittstabil]

Because of the test description, I believe the following makes more sense:

 test('patterns should be translated according to process.cwd()', t => {
        const previous = process.cwd();
-       const cwd = path.join(__dirname, 'fixtures/gitignore/test');
+       const cwd = path.join(__dirname, 'fixtures/gitignore');
        process.chdir(cwd);
        const result = manager.getGitIgnores({});
-       const expected = ['!foo.js', '!foo.js/**'];
+       const expected = ['!test/foo.js', '!test/foo.js/**'];
 
        t.deepEqual(result, expected);
        process.chdir(previous);
 });

[marionebl]

Done!

[schnittstabil]

👍 LGTM