Tweaks and refactoring #218
Conversation
|
open-editor – Nice, I have had the same idea 👍 |
|
@schnittstabil Hah, yeah. That is quite the coincidence and bad timing on my part... I started working on it last Sunday, but been waiting until now to get the package name from npm support (It was name grabbed). Should I push the change to integrate |
|
Feel free to integrate it, I won't be able to do it until this weekend. |
package.json
Outdated
| "index.js", | ||
| "cli.js", | ||
| "open-report.js", | ||
| "options-manager.js", |
There was a problem hiding this comment.
I think it's time to move files into a lib folder.
|
@sindresorhus updated (including a fix for |
| --cwd=<dir> Working directory for files | ||
| --stdin Validate/fix code from stdin | ||
| --stdin-filename Specify a filename for the --stdin option | ||
| --version Show the version number |
There was a problem hiding this comment.
I usually don't document this. It's implied knowledge. Same with --help.
Oh, can't believe I missed that... Thanks for noticing :) |
|
Yay! This is a huge improvement to the code base. Thank you for doing this @schnittstabil 🎉 Would you be interested in joining the project? ✨ |
|
I'd be glad to 😀 |
|
Awesome 🙌 |
Some refactoring to improve readability, modularity and testability.
Plus some basic tests for
opt.open--no-local.