Janury CPAN pull Request #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from Pof on lib/Text/CSV/Encoded.pm Signed-off-by: Jose Luis Perez Diez <jluis@escomposlinux.org>
Signed-off-by: Jose Luis Perez Diez <jluis@escomposlinux.org>
Signed-off-by: Jose Luis Perez Diez <jluis@escomposlinux.org>
Signed-off-by: Jose Luis Perez Diez <jluis@escomposlinux.org>
|
Thanks for this much appreciated. I ran through the build process and everything seems fine so I've pushed v 0.25 to CPAN |
|
Thanks >;), now I need to work on better commit messages for future CPR so the pull request looks nicer even if I don’t have time to rewrite the history on another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@singingfish I'm sorry to submit the pull request as it is but with FOSDEM in this weekend I'm not sure if I could make a clean set of pathches on time for the pull request challenge and I have sumited my test work branch and I plan to do a cleaner set of commits on another branch
This branch correctly addresses to your repository on meta when building with dzil , generates a README.pod for github (and another for the distro). it also integrates Kwalitee test.
Thanks for your time,
jluis