Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Prepare for CRAN [long-term tracker] #1582

Open
12 tasks
johnkerl opened this issue Aug 7, 2023 · 5 comments
Open
12 tasks

[r] Prepare for CRAN [long-term tracker] #1582

johnkerl opened this issue Aug 7, 2023 · 5 comments

Comments

@johnkerl
Copy link
Member

johnkerl commented Aug 7, 2023

Follow-on from #1567

  • ​​Add/update CRAN comments (this is not an actual requirement at CRAN)
  • ​​Submit to R-hub builder and verify no errors (prep for release to CRAN, not a GA blocker) (R-hub may fail due to our build process, is also challenged by our long list of dependencies, first attempt just failed for DE)
  • Audit relative to the one authorative manual Writing R Extensions (with nicer rendering here)
  • Audit relative to CRAN Repository Policy document
  • Change build process to not require download at build time, need to vendor in capnp and spdlog, see CRAN Repository Policy 'External Libries' and 'Using Rust' along with (on email list) preference for 'vendored' over downloaded (this may be a "maybe" as a) use system libs first and b) can ask for forgiveness here)
  • Pass R CMD check --as-cran on r-release as a minimal layer
  • Pass R CMD check --as-cran on r-devel (in docker, locally [ I keep it on Ubuntu ], rhub, win-builder (inapplicable, no Windows package), mac-builder (works, has cnake and git)
  • Pass R CMD check --use-valgrind (and inspect *.Rout files created) which currently errors and would lead to CRAN removal post-acceptance
  • Pass all the "informal checks" the "new package submission desk" runs on eg authors, credits, references, ...
  • Utilise experience of at least three contributors with active CRAN packages
  • Update our release procedure to reflect publishing to CRAN
  • Update the user-facing readme/docs to refer to CRAN instead of r-universe
@eddelbuettel
Copy link
Member

eddelbuettel commented Aug 7, 2023

In my experience the CRAN_comments.md is a myth. I have never heard anyone from CRAN recommending or requesting it yet I heard repeatedly that whatever was written in it was ignored. To be best of my understanding it serves primarily for pre-release notekeeping.

@eddelbuettel
Copy link
Member

I took the liberty of co-assigning @aaronwolen and @mojaveazure who both have 'CRAN battle experience' too.

@johnkerl
Copy link
Member Author

@eddelbuettel what steps remain to bring this issue to closure?

@eddelbuettel
Copy link
Member

There was a bit of a sentiment recently that maybe CRAN release does not buy as all that that we don't already have with r-universe. Happy to chat off-line.

@johnkerl johnkerl changed the title [r] Prepare for CRAN [r] Prepare for CRAN [long-term tracker] Apr 8, 2024
@johnkerl johnkerl removed the post-1.0r label Apr 8, 2024
@johnkerl
Copy link
Member Author

johnkerl commented Apr 8, 2024

Per internal discussion we will revisit this once TileDB-R has been removed as a dependency from TileDB-SOMA-R. See also #2406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants