Examples: s2regex in Rust #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlsverre
reviewed
Dec 13, 2022
pvetere
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Almost forgot about this -- could you add a little blurb for this example in the following README as well?
https://github.com/singlestore-labs/singlestore-wasm-toolkit/blob/main/examples/rust/README.md
* Use a single borrow of the compiled regex HashMap * perform a single get-or-lookup for each pattern
pvetere
reviewed
Dec 14, 2022
pvetere
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
This PR adds a simple
s2regexexample WASM rust crate supporting arbitrary regex matches on an input string.Misc
Makefile&writtests to thejsonpathexample