Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moving binary to sqllogictest-bin #66

Closed
skyzh opened this issue Aug 5, 2022 · 4 comments · Fixed by #67
Closed

refactor: moving binary to sqllogictest-bin #66

skyzh opened this issue Aug 5, 2022 · 4 comments · Fixed by #67
Assignees

Comments

@skyzh
Copy link
Member

skyzh commented Aug 5, 2022

It's becoming more and more complex, so it would be good to have a separate crate.

cc @xxchan do you want to work on this? If so feel free to assign yourself. Otherwise I'll do the refactor maybe this month.

@xxchan xxchan self-assigned this Aug 5, 2022
@wangrunji0408
Copy link
Member

Or consider moving some features into the library? Recently I'm working on deterministic e2e testing, where sqllogictest is used as a library.

@xxchan
Copy link
Member

xxchan commented Aug 6, 2022

🤔 I'm wondering:

  • Whether drivers live in lib or bin crate
  • Will we bump versions for them together in the future

Or consider moving some features into the library? Recently I'm working on deterministic e2e testing, where sqllogictest is used as a library.

How will moving binary affect your requirement? 🤔

@xxchan
Copy link
Member

xxchan commented Aug 6, 2022

I've drafted a PR #67, we can discuss there

@skyzh skyzh closed this as completed in #67 Aug 6, 2022
@wangrunji0408
Copy link
Member

wangrunji0408 commented Aug 8, 2022

How will moving binary affect your requirement? 🤔

It won't affect. The current refactor looks cool.
My point is to move some codes from sqllogictest-bin/lib.rs to sqllogictest/runner.rs, such as parallel running and printing progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants