Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner: Implement validator support #15

Merged
merged 4 commits into from
Jan 20, 2022
Merged

runner: Implement validator support #15

merged 4 commits into from
Jan 20, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Jan 19, 2022

This PR is a PoC for #13 to get a quick preview of my idea.

Welcome any comments.

@Xuanwo
runner: Implement validator support
54f3b9a 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 19, 2022

ping @skyzh to take a look.

@Xuanwo Xuanwo marked this pull request as draft January 19, 2022 09:55
@Xuanwo Xuanwo changed the title [PoC] runner: Implement validator support runner: Implement validator support Jan 20, 2022
@Xuanwo Xuanwo marked this pull request as ready for review January 20, 2022 05:37
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 20, 2022

Please let me know if we need an RFC for this feature.

skyzh
skyzh reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, thanks!

By the way, can we go a step further? e.g., add a Result associated type for DB, so that we can pass any type apart from String as query result. (Not needed in this PR)

Also, I would recommend adding an example for validator in examples folder.

src/runner.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 20, 2022

By the way, can we go a step further? e.g., add a Result associated type for DB, so that we can pass any type apart from String as query result. (Not needed in this PR)

Oh, so nice. Let's do it.

@Xuanwo
Make validator public
18e3d62 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request Jan 20, 2022
Closed
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 20, 2022

By the way, can we go a step further? e.g., add a Result associated type for DB, so that we can pass any type apart from String as query result. (Not needed in this PR)

Created a new issue #16 to track it.

@Xuanwo
Add example for test
fd5034b 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 20, 2022

Also, I would recommend adding an example for validator in examples folder.

Added. Maybe we should move some of them into tests instead.

@skyzh skyzh merged commit 8217d36 into risinglightdb:main Jan 20, 2022
@Xuanwo Xuanwo deleted the validator branch January 20, 2022 06:50
@Xuanwo Xuanwo mentioned this pull request Jan 26, 2022
Closed
@xxchan xxchan mentioned this pull request May 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@wangrunji0408 wangrunji0408 Awaiting requested review from wangrunji0408

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xuanwo @skyzh