Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 encode the authorization header #16

Closed
rene84 opened this issue Sep 23, 2022 · 1 comment
Closed

Base64 encode the authorization header #16

rene84 opened this issue Sep 23, 2022 · 1 comment
Labels
awaiting-response We're awating a response enhancement New feature or request

Comments

@rene84
Copy link

rene84 commented Sep 23, 2022

I understand the comment and intention here:

You'll note that we don't base64 the authorization header, so it's not technically Basic Auth, but I don't like Base64ing it because I believe that gives a false sense of security. Instead, you should enable TLS

However, the basic auth spec themselves mention that base64 has nothing to do with security and should be used in conjuction with TLS https://www.rfc-editor.org/rfc/rfc7617#section-1

The downside of not following the spec is integration efforts with libraries. For example, I want to use prom-client to push to gravel gateway but now I can't use the methods meant for that because they will obviously base64 the authorization header for me.

I would request the change to expect a base64 encoded authorization header to improve client integration. Or maybe just accept both ways for backwards compatibility

@sinkingpoint
Copy link
Owner

Yeah, that was mostly selfish of me. I've just published v1.6.0 that handles both, so that we don't break existing stuff - wanna check it out?

@sinkingpoint sinkingpoint added enhancement New feature or request awaiting-response We're awating a response labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response We're awating a response enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants