Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Customizable error UI in FeatureAppLoader/FeatureAppContainer #295

Closed
4 of 6 tasks
fahrradflucht opened this issue Jan 24, 2019 · 0 comments · Fixed by #557
Closed
4 of 6 tasks

React: Customizable error UI in FeatureAppLoader/FeatureAppContainer #295

fahrradflucht opened this issue Jan 24, 2019 · 0 comments · Fixed by #557

Comments

@fahrradflucht
Copy link
Member

fahrradflucht commented Jan 24, 2019

<FeatureAppLoader
  src="foo.js"
  renderError={error => <div>{error.toString()}</div>}
  onError={error => console.error(error)}
/>

Instead of throwing on the server we will call onError. We can remove the browser "Weiche".

Tasks

@fahrradflucht fahrradflucht added this to the Backlog milestone Jan 24, 2019
@clebert clebert changed the title Customizable error UI in FeatureAppLoader Customizable error UI in FeatureAppLoader/FeatureAppContainer Jan 24, 2019
@clebert clebert changed the title Customizable error UI in FeatureAppLoader/FeatureAppContainer React: Customizable error UI in FeatureAppLoader/FeatureAppContainer Mar 1, 2019
@clebert clebert modified the milestones: Backlog, Mathis Mar 4, 2019
@fahrradflucht fahrradflucht self-assigned this Mar 12, 2019
@clebert clebert modified the milestones: Wiehl Change, Backlog Jun 10, 2019
@unstubbable unstubbable removed their assignment Sep 27, 2019
remmycat pushed a commit that referenced this issue Feb 19, 2020
This deprecates the `renderError` prop.

fixes #296
fixes #295
remmycat added a commit that referenced this issue Feb 19, 2020
This deprecates the `renderError` prop.

fixes #296
fixes #295
@remmycat remmycat mentioned this issue Feb 19, 2020
unstubbable pushed a commit that referenced this issue Feb 19, 2020
This deprecates the `renderError` prop.

fixes #296
fixes #295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants