Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading UI #557

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Loading UI #557

merged 1 commit into from
Feb 19, 2020

Conversation

remmycat
Copy link
Contributor

@remmycat remmycat commented Jan 27, 2020 •
edited by unstubbable
Loading

Feature to allow for the integrator to show a generic loading UI, while the feature app is loading.

This deprecates the renderError prop.

fixes #296
fixes #295

@remmycat remmycat marked this pull request as ready for review February 6, 2020 11:48
@remmycat
Copy link
Contributor Author

remmycat commented Feb 6, 2020

@unstubbable Code & Tests are ready for review.
Docs and Sample App changes are still missing and following next week (I'm sick today)

It would be helpful if you could already start reviewing this part if you can make the time.

unstubbable
unstubbable requested changes Feb 7, 2020
View reviewed changes
Copy link
Member

@unstubbable unstubbable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort with the tests! 👏 Please excuse my whitespace review comments, this repo unfortunately adheres to an undocumented rule where newlines are added before and after multi-line statements. The main comment of my review is the one regarding the logic on componentDidMount.

packages/react/src/feature-app-container.tsx Outdated Show resolved Hide resolved
packages/react/src/feature-app-container.tsx Show resolved Hide resolved
packages/react/src/feature-app-loader.tsx Outdated Show resolved Hide resolved
packages/react/src/feature-app-container.tsx Outdated Show resolved Hide resolved
packages/react/src/feature-app-container.tsx Outdated Show resolved Hide resolved
packages/react/src/__tests__/feature-app-container.test.tsx Outdated Show resolved Hide resolved
packages/react/src/__tests__/feature-app-loader.test.tsx Outdated Show resolved Hide resolved
packages/react/src/__tests__/feature-app-loader.test.tsx Show resolved Hide resolved
packages/react/src/__tests__/feature-app-loader.test.tsx Show resolved Hide resolved
packages/react/src/__tests__/feature-app-loader.test.tsx Outdated Show resolved Hide resolved
@remmycat
Copy link
Contributor Author

@unstubbable @stemey As far as i can tell i handled everything you commentend and what we talked about.

(Demo & Docs still missing)

@remmycat
Copy link
Contributor Author

(force push was no-conflict rebase onto master only)

@remmycat remmycat changed the title Draft: Loading UI Loading UI Feb 19, 2020
@remmycat
feat(react): allow custom feature app rendering
e574484 
This deprecates the `renderError` prop.

fixes #296
fixes #295
@unstubbable unstubbable merged commit 03a967a into master Feb 19, 2020
@unstubbable unstubbable deleted the loading-ui branch February 19, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stemey stemey stemey left review comments

@unstubbable unstubbable unstubbable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@remmycat @unstubbable @stemey