Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small typos in matcher docs #2313

Closed
danielrentz opened this issue Nov 18, 2020 · 4 comments
Closed

Two small typos in matcher docs #2313

danielrentz opened this issue Nov 18, 2020 · 4 comments

Comments

@danielrentz
Copy link
Contributor

Describe the bug
The page for matchers contains two typos:

This allows to logically combine mutliple matchers. The result is a new matchers that requires both (and) or one of the matchers (or) to return true.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://sinonjs.org/releases/v9.2.1/matchers/
  2. Scroll down to 'Custom matchers'
  3. See error

Expected behavior
mutliple => multiple
matchers => matcher

@mantoni
Copy link
Member

mantoni commented Nov 20, 2020

Thank you. Would you care to make these changes yourself?

You can find instructions on how to make documentation changes here: https://github.com/sinonjs/sinon/blob/master/docs/CONTRIBUTING.md

@danielrentz
Copy link
Contributor Author

Sure. Where should I do the changes? In _releases/v9.2.1/ or in release-source/?

@fatso83
Copy link
Contributor

fatso83 commented Dec 2, 2020

Release-source.

@danielrentz
Copy link
Contributor Author

danielrentz commented Dec 2, 2020

#2315

@mantoni mantoni closed this as completed in e3a8fca Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants