1.8.1 breaks existing specs

[xcambar]

I've tried to upgrade to 1.8.1, but since then, I have the following error:

Here's the stack trace:

TypeError: '[object ProgressEventConstructor]' is not a constructor (evaluating 'new ProgressEvent("progress", {loaded: 100, total: 100})')
            at readyStateChange (/Users/xav/code/Hull.io/hull-js/node_modules/sinon/pkg/sinon.js:3663)
            at setResponseBody (/Users/xav/code/Hull.io/hull-js/node_modules/sinon/pkg/sinon.js:3814)
            at respond (/Users/xav/code/Hull.io/hull-js/node_modules/sinon/pkg/sinon.js:3824)
            at /Users/xav/code/Hull.io/hull-js/spec/remote/handler_spec.js:66
//and so on...

The line in the specs where the error originates is:

requests[0].respond(400, { 'Content-Type': 'application/json' }, '{}');

While a fix is pending, I will stay with 1.7.3 ;)

Best,

[fearphage]

Why didn't you send back a custom sinon.Event like everything else? This would allow XHR#upload events to be tested. Phantomjs currently doesn't have the ProgressEvent constructor, but my tests are going well using the sinon.Event. I did a find and replace of ProgressEvent with sinon.Event from the original commit.

[xcambar]

Following @fearphage comment, I should have ben more specific and told that specs were failing using Karma + PhantomJS.

[cjohansen]

@fearphage Mostly because I didn't write this code and made the most conservative change possible. Looking at it, I still think it's the right decision, cause I don't want Sinon to support something in an environment that doesn't also support the thing it's faking out (like ProgressEvent)

[mikehstrauss]

Has this issue been resolved? I just tried 1.8.1 and still see the problem.

[xcambar]

Then you should try 1.8.2 :p

[mikehstrauss]

I also tried 1.8.2, still an issue. Using Jasmine and Phantomjs. 1.7.3 works fine.

[xcambar]

Just double-checked. I too still have the issue.

[cjohansen]

Will push 1.8.3 shortly