Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producing diff in calledWith #773

Closed
hellboy81 opened this issue Jun 30, 2015 · 6 comments
Closed

Producing diff in calledWith #773

hellboy81 opened this issue Jun 30, 2015 · 6 comments

Comments

@hellboy81
Copy link

AssertionError: expected update to have been called with arguments {
...
}, {...}

functionName({...}, {,,,})

It is not easy to see difference.

Please provide diffs with red/green

@hdh3000
Copy link

hdh3000 commented Oct 23, 2015

@hellboy81 can you give a few more tangible examples? think i may have a fix, but its a bit unclear what you are asking for..

@jcrben
Copy link

jcrben commented Nov 7, 2016

You can draw some inspiration from a similar example with mocha. I found litixsoft/karma-mocha-reporter#32 which helped get mocha's colored diffing into the karma-mocha-reporter.

You can see what it looks like over at https://github.com/litixsoft/karma-mocha-reporter#showdiff

@jcrben
Copy link

jcrben commented Nov 8, 2016

fyi, just posted a $15 bounty for this https://www.bountysource.com/issues/23366130-producing-diff-in-calledwith

@fatso83
Copy link
Contributor

fatso83 commented Nov 18, 2016

http://unexpected.js.org might be worth a look.

@KaidenR
Copy link

KaidenR commented Jan 26, 2017

It looks like this may be duplicated (and fixed) in #1179

@fatso83 fatso83 closed this as completed Jan 27, 2017
@fatso83
Copy link
Contributor

fatso83 commented Jan 27, 2017

Fixed in sinon@next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants