Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

querystring.escape not sufficient #9

Closed
dfelder opened this issue Jan 15, 2012 · 3 comments
Closed

querystring.escape not sufficient #9

dfelder opened this issue Jan 15, 2012 · 3 comments

Comments

@dfelder
Copy link

dfelder commented Jan 15, 2012

querystring.escape doesn't escape !'()*. Dropbox allows at least a few of them in filenames and requires them to be escaped.
@tomgco
Copy link
Contributor

tomgco commented Jan 15, 2012

Yes although querystring.escape doesn't escape !'()* it can be overridden, however I seem to be able to create files using !'()* with no problems. What scenario does this fail for you?

@dfelder
Copy link
Author

dfelder commented Jan 15, 2012

My bad. The oauth.js lib takes perfectly care of it.

@dfelder dfelder closed this as completed Jan 15, 2012
@sintaxi
Copy link
Owner

sintaxi commented Jan 16, 2012

thanks for following up on this fellas :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sintaxi @tomgco @dfelder