Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump autoprefixer dependency. Also, an option to configure and/or disable it? #68

Open
PandaWhisperer opened this issue Oct 24, 2014 · 4 comments
Milestone

Comments

@PandaWhisperer
Copy link

With reference to this issue I filed on the harp project, it appears that terraform is using an outdated version of the autoprefixer module. With the web running at the blazing speed that it does, running something from July may already be old news in October. Certainly the browser world is moving very fast.

While we're at it, would it perhaps be possible to let the user configure the autoprefixer behavior via a _data.json setting, or, if necessary, completely disable it?

I'd be happy to prepare a pull request for this if that would help things out.

@kennethormandy
Copy link
Collaborator

Thanks for being so thorough on testing that! It makes it wayyy easier on us, it’s appreciated. 🍻

We have Autoprefixer v3.1.0 in queued up for Terraform v0.9.2 , our goal is to stay with the latests releases of the dependencies wherever it’s possible.

I don’t think we’ll make Autoprefixer configurable, but thanks for offering to help on that. We like Harp to avoid configuration where possible, it should just be a great set of defaults all the time, which we think includes Autoprefixer—we’ll have that outdated dependency sorted soon!

@sorahn
Copy link

sorahn commented Mar 1, 2015

I'm not sure if this belongs in here, but it's certainly related. I think that having autoprefixer is fine, but I'd really like to see minification turned off unless NODE_ENV == "production". It'd also be cool if non-production could generate source map output and the like.

You don't need to use minify in stylesheet/index.js, you can just have the sass.js files use 'nested' or 'compressed' based on the ENV.

I got into the terraform code to look at how to do that. I got it all turned on for node sass, and now I'm trying to trace out where the map output needs to go.

Would '.map' need to be another renderer that goes along with .scss.js and .sass.js, or is it something that can be piggy backed into the CSS output piplines.

@rocketnova
Copy link

@kennethormandy It looks like the current version of terraform (0.11.0) is using Autoprefixer 5.1.0. The current version of Autoprefixer is 5.2. Any plans to update to this version?

@kennethormandy kennethormandy modified the milestone: v1.0.0 Jan 6, 2016
@kennethormandy kennethormandy mentioned this issue Jan 7, 2016
6 tasks
@row-n
Copy link

row-n commented Jul 31, 2020

@kennethormandy The current Autoprefixer is now at version 9.8.6, are there any plans to update this? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants