New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minisketch.h uses deprecated C feature #18

Closed

rustyrussell opened this issue Aug 25, 2019 · 1 comment

Contributor

rustyrussell commented Aug 25, 2019

-Wall -Werror gives:

external/minisketch/include/minisketch.h:27:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
 uint32_t minisketch_implementation_max();
 ^~~~~~~~

For C code, this needs to be '(void)'. I think that's valid C++, but if not, it needs to go in #ifndef __cplusplus.

The text was updated successfully, but these errors were encountered:

Contributor

gmaxwell commented Dec 8, 2019

Fixed by #19

gmaxwell closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment