cflow.php and Call-IDs

[jawaidbazyar]

In links to call cflow.php to generate SIP call flows, homer embeds the SIP Call-ID in the URL like so:

https://x.x.x.xcflow.php?cid[]=0gQAAC8WAAACBAAALxYAANlMA4OugAeJ2H3q2Gu8ymMgjl+tP2m4mF46Zf3za9fjVQZazRsjYxyIhHskHSKkdg--@68.64.213.1&from_time=14:15:07&to_time=23:15:07&from_date=2014-12-30&to_date=2014-12-31&callid_aleg=0&popuptype=1&unique=0&location[]=1

That is an actual SIP Call-ID from my company's softswitch, a MetaSwitch.

There is a problem with this approach.

First off, SIP Call-ID's are allowed to contain the "+" character. See page 220 of:

https://www.ietf.org/rfc/rfc3261.txt

A SIP Call-ID is defined as word [ @ word ] , and a word is defined as:

word = 1_(alphanum / "-" / "." / "!" / "%" / "" /
"" / "+" / "`" / "'" / "~" /
"(" / ")" / "<" / ">" /
":" / "" / DQUOTE /
"/" / "[" / "]" / "?" /
"{" / "}" )

While it is clear that many SIP agents do not include "+" characters in Call-ID, my softswitch and/or SBC do (both are products of MetaSwitch).

The impact of a "+" in Call-ID is that PHP urldecodes the query string, and converts a + to a space character, as "+" has a special meaning in URLs.

Call-IDs should be URL-encoded.

[jawaidbazyar]

I see that I may not have been clear in my explanation of the problem above.

What happens here is that when I click on a Call-ID in a search display, I get a "No Data Found!" error as PHP receives a Call-ID with + transmuted to 'space'. Thus, it cannot find the right records in the sip_capture table.

[adubovikov]

yes, this is well known bug, need to decode all callid parameters to URL hash or json.

[adubovikov]

can you please check the last git ?

[adubovikov]

ok, looks like it fixed. If not, please reopen the ticket.

[jawaidbazyar]

Hi, last git does not fix the issue with "+" in the call-id.

I made patches that make it work - In several places I added encoding (and, in one case, double-encoding).

http://tny.cz/3986f276