Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popover arrow style #369

Closed
luxzeitlos opened this issue Jul 22, 2019 · 2 comments
Closed

popover arrow style #369

luxzeitlos opened this issue Jul 22, 2019 · 2 comments
Labels
3.x ember-tooltips Release series 3.x bug has-pr Has pending PR
Milestone

Comments

@luxzeitlos
Copy link

This is probably related to #368

Currently we specify arrow styles in out css but in a way so its never ever applied.

Because of that logic the arrow gets rendered with the style ember-popover-arrow not ember-tooltip-arrow.

However when we fix this things get interesting:
The arrow looks horrible. Its basically just white hiding the border there, not actually showing an arrow.

Shouldn't we either a) fix this or b) remove the arrow scoresheets for popovers altogether?

@andycochran
Copy link
Contributor

This is addressed in #370.

@maxfierke maxfierke added 3.x ember-tooltips Release series 3.x bug has-pr Has pending PR labels Jul 27, 2019
@maxfierke maxfierke added this to the 3.4.0 milestone Jul 30, 2019
@maxfierke
Copy link
Collaborator

#370 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x ember-tooltips Release series 3.x bug has-pr Has pending PR
Projects
None yet
Development

No branches or pull requests

3 participants