Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate tests #8

Closed
sirbrillig opened this issue Nov 12, 2017 · 2 comments · Fixed by #14
Closed

Automate tests #8

sirbrillig opened this issue Nov 12, 2017 · 2 comments · Fixed by #14

Comments

@sirbrillig
Copy link
Owner

The tests should be able to run with a simple call to composer test.

@GaryJones
Copy link
Contributor

It would be good to get some instructions written up as well, even if the tests are ultimately then available via composer test.

I started to put together something to run the tests, but seemed to be going down a rabbit hole that may not have been necessary. I guess you'd been running tests already, but I hadn't figured out how you were doing that.

Do be aware though, that it should cater for PHPUnit and PHPCS NOT being available globally - i.e. they should be require-dev dependencies, and any paths to them reference vendor/bin/php* instead of global installs.

Tieing this all into a Travis CI webhook would be the obvious next step afterwards.

@sirbrillig
Copy link
Owner Author

Now the tests can be run with composer test. I made #15 to cover adding CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants