which CardDefs.xml do you use?

[1576012404]

it seems that some cards in CardDefs.xml are not implemented in fireplace,so which vision of CardDefs.xml do you use?

the link:https://github.com/HearthSim/hsdata

[sirmammingtonham]

I used the standard CardDefs.xml, but I only trained with the core/basic card set. There's a function in gameUtils.py that allows you to exclude all cards in training except for a specified set

alphastone/alphabot/utils/gameUtils.py

Lines 26 to 35 in 06e633b

	def isolateSet(self, filename='notbasicset', set='CardSet.CORE'):
	# isolates the specified card set for exclusion in drafting
	cards.db.initialize()
	extraset = []
	for index, card in cards.db.items():
	if str(card.card_set) != set:
	extraset.append(card.id)
	with open(f'{filename}.data', 'wb') as filehandle:
	# store the data as binary data stream
	pickle.dump(extraset, filehandle)

so the non-implemented cards are ignored. This will be called if is_basic=True.
Hopefully fireplace is still being worked on so more cards can be implemented soon.

[1576012404]

i run the code with default parameters,so it use the notbasicset files of yours. i can also finds some cards whose effects are not implemented.