Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in section 5 #21

Closed
hobbsy opened this issue Jan 20, 2020 · 7 comments
Closed

Typo in section 5 #21

hobbsy opened this issue Jan 20, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@hobbsy
Copy link
Contributor

hobbsy commented Jan 20, 2020

small typo in section 5

https://github.com/sirredbeard/Awesome-WSL#5-wsl2

"users can try WSL2 using Hypver-V"

*Hyper-V
@sirredbeard
Copy link
Owner

Why don't you submit a PR so you can have a commit credit on the project? 🙂

@hobbsy
Copy link
Contributor Author

hobbsy commented Jan 20, 2020

I don't know how to do that - but will Google as I want to learn how to contribute to Github projects this year.

Is flagging a typo helpful or a nuisance?

@sirredbeard
Copy link
Owner

Very helpful.

A PR is even more helpful.

I wanted to encourage you to try yourself though. 😉

@hobbsy
Copy link
Contributor Author

hobbsy commented Jan 26, 2020

Thanks for the encouragement. I've attempted a Pull Request - but I'm not sure if I've done it right?

@sirredbeard
Copy link
Owner

PR merged.

@sirredbeard sirredbeard added the enhancement New feature or request label Jan 31, 2020
@hobbsy
Copy link
Contributor Author

hobbsy commented Jan 31, 2020

Can I now delete the fork from my Github profile ?

eg.
https://github.com/hobbsy/Awesome-WSL

"Delete this repository"

or does it need to stay ?

@sirredbeard
Copy link
Owner

You can delete it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hobbsy @sirredbeard