Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process images with LinkRenderer (fixes #95) #115

Merged
merged 2 commits into from Dec 9, 2013
Merged

Process images with LinkRenderer (fixes #95) #115

merged 2 commits into from Dec 9, 2013

Conversation

gitblit
Copy link
Contributor

@gitblit gitblit commented Oct 25, 2013

The proposed patch allows interception of image tag generation with the LinkRenderer allowing the same type of manipulation flexibility as already offered for explicit links, wiki links, etc.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 6, 2013

@sirthias What can I do to move this pull request forward?

@sirthias
Copy link
Owner

sirthias commented Nov 8, 2013

Sorry, James, I've been incredibly busy these last weeks.
If you add a couple of tests for this new feature I have no problem with merging this patch.
Thanks!

@gitblit
Copy link
Contributor Author

gitblit commented Nov 8, 2013

I was afraid you'd say that as your tests are written in Scala - which is something I don't know how to use. Maybe I will give it a shot this weekend.

@sirthias
Copy link
Owner

sirthias commented Nov 8, 2013

This is the perfect opportunity to give it a shot!
All you need to do is to install sbt, change into the project root and call sbt.
Once you are in the sbt shell you simply say test.
Writing the tests should be pretty self-explanatory, even you have never written a single line of Scala before.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 9, 2013

@sirthias I've gotten sbt testing working on Fedora. I didn't add any new test cases but I did discover that my changes cause the existing suite to fail... because they actually improve the rendered output. I adjusted the expected output of Maruku/images.html to include the title attribute which was previously discarded but is now properly rendered. So this PR is a fix and a feature, all-in-one.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 14, 2013

@sirthias Sorry to nag. Have you reviewed these changes? I'd like to ship a new release of Gitblit in December which depends on an officially released pegdown with this patch.

@gitblit
Copy link
Contributor Author

gitblit commented Nov 29, 2013

@sirthias ping.

sirthias added a commit that referenced this pull request Dec 9, 2013
Process images with LinkRenderer (fixes #95)
@sirthias sirthias merged commit 4d74266 into sirthias:master Dec 9, 2013
@sirthias
Copy link
Owner

sirthias commented Dec 9, 2013

Sorry it took so long.
Just merged, packaged, pushed, tagged and released pegdown 1.4.2 containing your patch....

Thanks again!

@gitblit gitblit deleted the imagevisitor branch December 9, 2013 15:45
@gitblit
Copy link
Contributor Author

gitblit commented Dec 9, 2013

Awesome! Thank you. When you say released do you mean you pushed a new jar to Sonatype for syncing to MavenCentral? That'll be the next thing I need.

@sirthias
Copy link
Owner

sirthias commented Dec 9, 2013

Yes, the 1.4.2 JAR should be available from sonatype releases and be synced to maven central shortly.

@gitblit
Copy link
Contributor Author

gitblit commented Dec 10, 2013

Works great, THANK YOU!!

@gitblit
Copy link
Contributor Author

gitblit commented Dec 12, 2013

I updated my "next" demo server with Pegdown 1.4.2 for the merged image visitor. This allows me to load images relative to the repository.

Check it out here:
https://next-gitblit.rhcloud.com/docs/mirrors!butterknife.git

The android/plate image is loaded relative to the document from the repository.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants