New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process images with LinkRenderer (fixes #95) #115
Conversation
@sirthias What can I do to move this pull request forward? |
Sorry, James, I've been incredibly busy these last weeks. |
I was afraid you'd say that as your tests are written in Scala - which is something I don't know how to use. Maybe I will give it a shot this weekend. |
This is the perfect opportunity to give it a shot! |
@sirthias I've gotten sbt testing working on Fedora. I didn't add any new test cases but I did discover that my changes cause the existing suite to fail... because they actually improve the rendered output. I adjusted the expected output of Maruku/images.html to include the |
@sirthias Sorry to nag. Have you reviewed these changes? I'd like to ship a new release of Gitblit in December which depends on an officially released pegdown with this patch. |
@sirthias ping. |
Process images with LinkRenderer (fixes #95)
Sorry it took so long. Thanks again! |
Awesome! Thank you. When you say released do you mean you pushed a new jar to Sonatype for syncing to MavenCentral? That'll be the next thing I need. |
Yes, the 1.4.2 JAR should be available from sonatype releases and be synced to maven central shortly. |
Works great, THANK YOU!! |
I updated my "next" demo server with Pegdown 1.4.2 for the merged image visitor. This allows me to load images relative to the repository. Check it out here: The android/plate image is loaded relative to the document from the repository. |
The proposed patch allows interception of image tag generation with the LinkRenderer allowing the same type of manipulation flexibility as already offered for explicit links, wiki links, etc.