Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost puppies can cause data loss / duplication in an edge case #38

Open
sisby-folk opened this issue Mar 13, 2023 · 0 comments
Open

Lost puppies can cause data loss / duplication in an edge case #38

sisby-folk opened this issue Mar 13, 2023 · 0 comments
Labels
bug Something isn't working core An improvement or fix for switchy-core

Comments

@sisby-folk
Copy link
Owner

Currently the data recovery system will load data straight back into modules when they're reinstalled, but that won't have any effect on the current preset.

What this means practically is that swapping the current preset while a module is uninstalled will cause you to copy data from the old current preset to the new one, erasing what was already there - both a data loss and dupe condition.

It's been a while since we've considered running applyToPlayer() on game start, so we don't remember whether it was just unneccesary or whether it was striaght-up impossible - but doing so would resolve the issue.

@sisby-folk sisby-folk added bug Something isn't working core An improvement or fix for switchy-core labels Apr 17, 2023
@sisby-folk sisby-folk changed the title Minor flaw in the "lost puppy" system. Lost puppies can cause data loss / duplication in an edge case Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core An improvement or fix for switchy-core
Projects
None yet
Development

No branches or pull requests

1 participant