Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regexp with i modifier is slow #258

Merged
merged 3 commits into from Feb 4, 2018
Merged

Regexp with i modifier is slow #258

merged 3 commits into from Feb 4, 2018

Conversation

azumakuniyuki
Copy link
Member

  • Remove /i modifiler from each regular expression as possible
  • lc($v) before passing string to Sisimai::Reason::*::match() method

@coveralls
Copy link

coveralls commented Feb 4, 2018 •
edited

Coverage Status

Coverage increased (+0.03%) to 95.296% when pulling f387d27 on regexp-with-i-modifier-is-slow into d256815 on master.

@azumakuniyuki azumakuniyuki merged commit 2b6578c into master Feb 4, 2018
azumakuniyuki added a commit to sisimai/rb-sisimai that referenced this pull request Feb 5, 2018
@azumakuniyuki
Import Pull-Request sisimai/p5-sisimai#258 as possible
c2434d4
@azumakuniyuki azumakuniyuki mentioned this pull request Feb 5, 2018
Merged
azumakuniyuki added a commit that referenced this pull request Feb 5, 2018
@azumakuniyuki
Follow up Pull-Request #258
9305bfa
azumakuniyuki added a commit that referenced this pull request Feb 5, 2018
@azumakuniyuki
Follow up Pull-Request #258
9a75ae9
@azumakuniyuki azumakuniyuki deleted the regexp-with-i-modifier-is-slow branch July 20, 2018 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azumakuniyuki @coveralls