Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less method calls #290

Merged
merged 4 commits into from Aug 30, 2018
Merged

Less method calls #290

merged 4 commits into from Aug 30, 2018

Conversation

azumakuniyuki
Copy link
Member

  • Do not use redundant length()
  • Do not use redundant require()
  • Do not check an argument class repeatedly

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 95.703% when pulling cdf7b2c on less-method-calls into cccb4ef on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 95.703% when pulling cdf7b2c on less-method-calls into cccb4ef on master.

@azumakuniyuki azumakuniyuki merged commit 724b524 into master Aug 30, 2018
@azumakuniyuki azumakuniyuki deleted the less-method-calls branch November 11, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azumakuniyuki @coveralls