Reduce Regular Expressions #490

azumakuniyuki · 2023-01-21T07:58:17Z

Reduce 67% of regular expressions
Implement the following methods:
- Sisimai::SMTP::Command->test
- Sisimai::SMTP::Reply->test
- Sisimai::SMTP::Status->test
- Sisimai::SMTP::Status->prefer
- Sisimai::String->aligned
- Sisimai::String->ipv4
Rename the following classes:
- Sisimai::Rhost::Microsoft (ExchangeOnline)
- Sisimai::Rhost::Google (GoogleApps)
- Sisimai::Rhost::Tencent (TencentQQ)
- And sample emails in set-of-emails/ for classes above

…rated by Courier or not

…find is undefined

…ode(D.S.N.) is a valid code or not

…ence

…g->aligned()

…:String->aligned()

…g->aligned

…ssage

…an error message

azumakuniyuki added 28 commits January 13, 2023 19:04

Reduce regular expression

f207499

Reduce regular expressions in Sisimai::Address->find

a69f079

Changed the 1st argument of Sisimai::Address->undisclosed()

3d1cd6a

Remove the old code in comment at Sisimai::Address->find

c99b183

Reduce regular expressions for checking whether a bounce mail is gene…

928303b

…rated by Courier or not

Reduce regular expressions in lib/Sisimai/Lhost/*

181f002

Set an empty string when the return value of Sisimai::SMTP::Command->…

1846389

…find is undefined

Implement Sisimai::SMTP::Command->test method

7586b17

Reduce regular expressions

ff878d9

Reduce regular expressions in Sisimai::SMTP::Transcript

bade6c5

Reduce regular expressions

b12905a

Reduce regular expressions, remove unused code block

afcc7f7

Reduce regular expressions

db5bfa8

Implement Sisimai::SMTP::Status->test for checking whether a status c…

7aa28cc

…ode(D.S.N.) is a valid code or not

Reduce regular expressions

7d0f1eb

Reduce regular expressions

6688bf2

Implement Sisimai::String->aligned

8ea692b

Change the 1st argument of Sisimai::String->aligned to a scalar refer…

d2f3f2d

…ence

Call Sisimai::String->aligned instead of grep { ... long code }

7c44e30

Reduce regular expressions

a32138b

Update test results

d2341bb

Reduce regular expressions using index(), substr() and Sisimai::Strin…

19c5328

…g->aligned()

Add a test case for checking the 2nd argument have a 1 element

bd33e2a

Reduce some regular expressions using index(), substr(), and Sisimai:…

a345fed

…:String->aligned()

Reduce regular expressions, and Rename some classes in Sisimai::Rhost::*

25745c4

Reduce regular expressions using index(), substr() and Sisimai::Strin…

ca3b8df

…g->aligned

Remove some require statement which are already called at Sisimai::Me…

e8e3479

…ssage

Implement Sisimai::SMTP::Reply->test method

76d2776

azumakuniyuki added the improvement label Jan 21, 2023

azumakuniyuki self-assigned this Jan 21, 2023

azumakuniyuki added 25 commits April 22, 2023 15:45

Tiny code improvement

21c4b44

Reduce regular expression

51ee37e

Tiny code improvement

887db45

Reduce regular expressions

9ec8eec

Tiny code improvement

96aa09d

Reduce regular expression

355eb1b

Reduce regular expression

74eb4eb

Change the variable name: $issuedcode

dc685a0

Reduce regular expressions

02463e1

Reduce regular expressions

60bef1b

Remove unused variable $argv3

a82871e

Code improvement for detecting an SMTP command

ec9b84f

Change the order of elements in $pairs

143f31c

Variable names have been changed

4097448

Tiny code improvement

b242998

Bug fix at the code to get the value of a remote host address

a93dde2

Tiny code improvement in Sisimai::Address->find

1f7084e

Tiny code improvement in Sisimai::SMTP::Status->prefer

8c64f13

Tiny code improvement in Sisimai::ARF->inquire

b532bc5

Reduce regular expression in Sisimai::Lhost::Bigfoot

85effed

Add a test code for Sisimai::SMTP::Status->prefer

0618bec

Fix code for index()

1c72a0f

Tiny code improvement in Sisimai::SMTP::Reply->find()

f24ef68

Tiny code improvement in Sisimai::Lhost::GSuite->inquire for getting …

15833ce

…an error message

Tiny code improvement

fdf49df

azumakuniyuki added the enhancement label May 8, 2023

azumakuniyuki merged commit 0c60351 into 5-beta5 May 8, 2023

Sisimai 5 automation moved this from To Do to Done May 8, 2023

azumakuniyuki added a commit that referenced this pull request May 9, 2023

Update the release notes about #490

f60abd2

azumakuniyuki deleted the 7e71-reduce-regular-expressions branch February 5, 2024 04:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce Regular Expressions #490

Reduce Regular Expressions #490

azumakuniyuki commented Jan 21, 2023 •

edited

Reduce Regular Expressions #490

Reduce Regular Expressions #490

Conversation

azumakuniyuki commented Jan 21, 2023 • edited

azumakuniyuki commented Jan 21, 2023 •

edited