Fix for JRuby 9.2 or later #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
azumakuniyuki
commented
Mar 6, 2024
azumakuniyuki
commented
- It worked at JRuby 9.3
- strptime fails on JRuby 9.2.9.0 #159
- Is anyone running Sisimai on JRuby? #267
…erpreted as binary operator #267
…t MRI 2.5 or later #267 #269 Thanks to @hiroyuki-sato
There was a problem hiding this comment.
@azumakuniyuki I left a minor comment. Please check when you get a chance.
.github/workflows/rake-test.yml
Outdated
| matrix: | ||
| cruby: ["2.4", "2.7", "3.0", "3.3"] | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
minor: You will find the deprecated message. checkout@v4 available. You just need to change v2 -> v4
https://github.com/actions/checkout
There was a problem hiding this comment.
@hiroyuki-sato Thanks for the review, I'll use v4 :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.