Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r111 documentation page is missing #1570

Closed
tgrushka opened this issue Feb 12, 2024 · 2 comments
Closed

r111 documentation page is missing #1570

tgrushka opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
bug Report of unexpected or faulty behaviour in Alfa

Comments

@tgrushka
Copy link

The expected documentation for this R111 Target Size rule at:

https://alfa.siteimprove.com/rules/sia-r111

currently returns a 404 error.

Can't seem to find where these doc pages are generated in the code (if they are).

Thanks for the great test suite!

@tgrushka tgrushka added the bug Report of unexpected or faulty behaviour in Alfa label Feb 12, 2024
@Jym77 Jym77 added this to 📮 Backlog in ⚙️ Development via automation Feb 12, 2024
@Jym77 Jym77 self-assigned this Feb 12, 2024
@Jym77
Copy link
Contributor

Jym77 commented Feb 12, 2024

Hi @tgrushka, thanks for using Alfa.

Indeed, we haven't written that documentation yet…
The reason is that the corresponding ACT rule is still in early development and I expect it to change, plus I also expect R111 to change after seeing how it actually runs (I know there are several corner cases it doesn't handle, and want to gather data on what is actually used on the web before over-engineering it).

So, I expect the rule to change significantly in the short term and did not want to write too much documentation that will soon get outdated.


In its current state, the rule simply looks at the bounding box of focusable widgets and checks that it is at least 44×44px.
This clearly leaves some false negative (accepting too much) in case of rounded corners or rotated content (these are acceptable).
This doesn't handle some of the WCAG exception around "User Agent size" (we can probably do something around it) or "essential size" (this, we probably won't be able to manage within Alfa).


These pages are generated from another repository that is private. I'm not 100% sure why it was set up like that, but haven't reverted that decision yet.

@Jym77
Copy link
Contributor

Jym77 commented Apr 10, 2024

Hi @tgrushka , we've written and published the documentation for R111 (and R113, for 2.5.8). Closing this.

@jrpool, FYI.

@Jym77 Jym77 closed this as completed Apr 10, 2024
⚙️ Development automation moved this from 📮 Backlog to 🏁 Done Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of unexpected or faulty behaviour in Alfa
Projects
⚙️ Development
  
🏁 Done
Development

No branches or pull requests

2 participants