Add support for NSplitView #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JannThomas
requested changes
Apr 24, 2021
|
@steipete I understand this is a very old PR, but I figured I'd add some tests and merge it anyway. In general, I don't understand why the library doesn't vend controller introspection functions the way it does for iOS. Maybe fiddling with controllers isn't as customary a practice on macOS. I wouldn't know as I'm an iOS developer. For now, I'll rename the method to |
|
Awesome, great to see this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for introspecting
NSplitView.We could also expose
NSplitViewControllerinstead, it's accessible by simply callingdelegateon the AppKit view. So far the AppKit part didn't expose any controller so not sore what's preferred - the name currently doesn't fully add up.I'm using this in my sideproject to hide the detail view on-demand, works just as needed.