Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where introspecting within a LazyVStack would silently fail #153

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

crayment
Copy link
Contributor

@crayment crayment commented Apr 19, 2022

I ran into the issue described in #140 and the fix described worked for me. We are using introspectScrollView within a LazyVStack and without this fix introspect fails when the scrollview is "below the fold". In our case we have nested ScrollViews something like this:

ScrollView(.vertical) {
    LazyVStack {
        ScrollView(.horizontal) {
        }
        .introspectScrollView {
            // This fails when the horizontal scrollview is below the fold.
        }
    }
}

@crayment crayment closed this Apr 20, 2022
@crayment crayment reopened this Apr 27, 2022
@gopalkrishnareddy
Copy link

We have the same issue, when can we expect the PR to get merged?

@yoller
Copy link

yoller commented Jul 20, 2022

Same here, waiting for the PR get merged! Thnx

@SplittyDev SplittyDev merged commit d3cbf32 into siteline:master Aug 21, 2022
@SplittyDev
Copy link
Collaborator

Thanks a lot 👍 Merged!

@crayment crayment mentioned this pull request Sep 9, 2022
okmyself added a commit to okmyself/SwiftUI-Introspect that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants