Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation/route option based providers #3

Open
sagikazarmark opened this issue Dec 9, 2015 · 1 comment
Open

Annotation/route option based providers #3

sagikazarmark opened this issue Dec 9, 2015 · 1 comment
Milestone

Comments

@sagikazarmark
Copy link

I would like to do automatic generation of URLs like here:

https://github.com/prestaconcept/PrestaSitemapBundle/blob/master/Resources/doc/4-Usage-Annotation.md

Would you accept a PR for such an implementation? Basically I would just loop through the RouteCollection and check if specific options are found.

Since there is some sort of dependency for symfony router here, I would submit it here instead of the bundle.

@K-Phoen
Copy link
Member

K-Phoen commented Dec 10, 2015

Sure, I'd be happy to review a PR for that 👍

Do not hesitate to open one even if it's still a WIP.

@K-Phoen K-Phoen added this to the 2.0 milestone Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants