Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable widget titles #43

Closed
dimitrov-adrian opened this issue Mar 10, 2015 · 7 comments
Closed

Unreadable widget titles #43

dimitrov-adrian opened this issue Mar 10, 2015 · 7 comments

Comments

@dimitrov-adrian
Copy link
Contributor

In some cases where widget have long titles, the text could became unreadable.

screen shot 2015-03-10 at 21 44 35

I think (also have tested), the problem could be fixed if we set these list items to be inline-block instead of list-item which is default for

  • elements

    So possible fix here is

    tpl/js-templates.php

    <li class="widget-type" style="display:inline-block;">
    

    and css/admin.css in rule

    .so-panels-dialog.so-panels-dialog-add-widget .widget-type-list .widget-type
    

    we could add vertical-align: top; to ensure they will be nicely arranged

  • @gregpriday
    Copy link
    Member

    This is something I've been meaning to fix for a while now. Turns out, it was actually fairly easy. I've committed to the develop branch if you want to take a look.

    0be9871

    screen shot 2015-03-11 at 3 13 15 am

    @gregpriday
    Copy link
    Member

    Something else I'd like to do is add some JS to match the height of all the widgets in a given row. Just to neaten things up a little bit.

    @gregpriday
    Copy link
    Member

    Just added Javascript based height balancing. Still need to test this fully, but it's a decent start.

    f25a0b1

    screen shot 2015-03-11 at 6 50 33 am

    @ghost
    Copy link

    ghost commented Mar 11, 2015

    Stunning work @gregpriday
    Much nicer

    @dimitrov-adrian
    Copy link
    Contributor Author

    Yeah, look better :) Unfortunately have no IE to test.

    @tareiking
    Copy link
    Contributor

    @gregpriday Really like how the balancing is on a row basis vs. all blocks get the max. height applied - nice work.

    @dimitrov-adrian You can test IE both remotely and locally via : http://www.browserstack.com/

    @braamgenis
    Copy link
    Contributor

    Tested with IE9 (from modern.ie) and IE11 and it looks like it's working well. Nicely done. @gregpriday

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Development

    No branches or pull requests

    4 participants