-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreadable widget titles #43
Comments
This is something I've been meaning to fix for a while now. Turns out, it was actually fairly easy. I've committed to the develop branch if you want to take a look. |
Something else I'd like to do is add some JS to match the height of all the widgets in a given row. Just to neaten things up a little bit. |
Just added Javascript based height balancing. Still need to test this fully, but it's a decent start. |
Stunning work @gregpriday |
Yeah, look better :) Unfortunately have no IE to test. |
@gregpriday Really like how the balancing is on a row basis vs. all blocks get the max. height applied - nice work. @dimitrov-adrian You can test IE both remotely and locally via : http://www.browserstack.com/ |
Tested with IE9 (from modern.ie) and IE11 and it looks like it's working well. Nicely done. @gregpriday |
In some cases where widget have long titles, the text could became unreadable.
I think (also have tested), the problem could be fixed if we set these list items to be inline-block instead of list-item which is default for
So possible fix here is
tpl/js-templates.php
and css/admin.css in rule
we could add
vertical-align: top;
to ensure they will be nicely arrangedThe text was updated successfully, but these errors were encountered: