Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Handle response images in 'avoidscailingimaqges' advice. #7

Closed
tobli opened this issue Feb 10, 2016 · 0 comments
Closed

Handle response images in 'avoidscailingimaqges' advice. #7

tobli opened this issue Feb 10, 2016 · 0 comments
Assignees

Comments

@tobli
Copy link
Member

tobli commented Feb 10, 2016

If avoidscailingimaqges advice can report incorrect image urls for img tags with srcset, but no src. http://www.aftonbladet.se/ is one such size (at least at the time of reporting). Since no src is present, the url get's reported as http://www.aftonbladet.se/.

Finding candidate images can be done with the following snippet:
Array.prototype.slice.call(document.getElementsByTagName('img')).filter((img) => img.src === '')

The coach needs to consider srcset, and update advice accordingly.

@soulgalore soulgalore self-assigned this Feb 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants